Skip to content

8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError #3277

wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 13, 2025 •
edited by openjdk bot
Loading

Hi all,

JMH tests org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark report fails "java.lang.NoClassDefFoundError: jdk/incubator/vector/VectorSpecies" in jdk17u-dev repo.

This failure was fixed by JDK-8284960 in main-line repo, I think it's not suitable backport JDK-8284960 to jdk17u-dev. So I create this issue to fix failure.

Change has been verified locally, test-fix only, no risk.

Verify command:

build/linux-x86_64-server-release/images/jdk/bin/java -Djmh.ignoreLock=true -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED --add-opens java.base/sun.security.provider=ALL-UNNAMED --add-opens java.base/com.sun.crypto.provider=ALL-UNNAMED -jar $PWD/build/linux-x86_64-server-release/images/test/micro/benchmarks.jar -jvmArgsPrepend -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native -t 1 -f 1 -wi 2 org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark.testFirstTrueByte

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349974 needs maintainer approval

Issue

  • JDK-8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3277/head:pull/3277
$ git checkout pull/3277

Update a local copy of the PR:
$ git checkout pull/3277
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3277

View PR using the GUI difftool:
$ git pr show -t 3277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3277.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2025 •
edited
Loading

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 231 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Could anyone take look this PR.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take look this PR.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the reviews @phohensee.

/approval request Fix a JMH test bug which cause test run fails. Change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@sendaoYan
8349974: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 18, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2025

Going to push as commit e38a5f6.
Since your change was applied there have been 232 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2025
@openjdk openjdk bot closed this Apr 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2025
@openjdk
Copy link

openjdk bot commented Apr 19, 2025

@sendaoYan Pushed as commit e38a5f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8349974 branch April 19, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sendaoYan @phohensee